Viewing Issue Advanced Details
ID 0002716 Category [DMDirc] IRC Parser Severity minor
Reproducibility always Date Submitted 2009-07-03 09:18 Last Update 2009-11-21 22:56
Reporter Error Reporter Assigned To Dataforce View Status public
Priority normal Status closed Resolution fixed
Platform Fixed in Version Target Version 0.6.3m2
Product Version Product Build
Summary 0002716: OnPost005 fired too early on WeIRCd
Description
OnPost005 fired too early on WeIRCd
Needs unit test no
Upstream Bug URL

Relationships
related to 0002697closedMD87 User context menu offers (de)op/(de)voice but not (de)halfop even if 005 CHANMODE info of a server indicates that halfop is avai 

Notes
(0007067)
MD87 (administrator)
2009-07-03 09:22

 09:16:52 | >> NICK Chris
09:16:52 | >> USER chris 192.168.30.110 irc.Eloxoph.com :...
09:16:52 | << NOTICE AUTH :*** Welcome. Send your authentication
09:16:52 | << PING :1246609010
09:16:52 | >> PONG :1246609010
09:16:52 | << :friendly.landlord.eloxoph.com 001 Chris :Welcome to Eloxoph Chris
09:16:52 | << :friendly.landlord.eloxoph.com 002 Chris :Your host is friendly.landlord.eloxoph.com, running WeIRCd0.7
09:16:52 | << :friendly.landlord.eloxoph.com NOTICE Chris :*** Your host is friendly.landlord.eloxoph.com, running WeIRCd0.7
09:16:52 | >> PING 1246609012758
09:16:52 | << :friendly.landlord.eloxoph.com 003 Chris :This server was created on a rainy monday
09:16:52 | << :friendly.landlord.eloxoph.com 004 Chris friendly.landlord.eloxoph.com WeIRCd0.7 BorS bcihklmnOorstv
09:16:52 | << :friendly.landlord.eloxoph.com 005 Chris CHANTYPES=# PREFIX=(ohv)@%+ NETWORK=Eloxoph AWAYLEN=200 TOPICLEN=300 :are supported by this server
09:16:52 | << :friendly.landlord.eloxoph.com 005 Chris CHANLIMIT=#:12 IRCD=WeIRCd NICKLEN=25 CASEMAPPING=ascii USERLEN=9 :are supported by this server
09:16:52 | << :friendly.landlord.eloxoph.com 005 Chris CHANMODE=b,kl,,cimnOrst PENALTY MAXTARGETS=1 MAXBANS=50 MODES=5 :are supported by this server
09:16:52 | << :friendly.landlord.eloxoph.com 251 Chris :There are 9 users on 0 servers

I have an action for SERVER_CONNECTED (which is fired in the onPost005 callback), and its output appears before the friendly.landlord.eloxoph.com NOTICE.

Presumably this is because the NOTICE is of a type that's sent post-registration rather than AUTH style. Hyperion sends:

09:20:08 | << NOTICE Chris :*** Your host is sendak.freenode.net[sendak.freenode.net/6667], running version hyperion-1.0.2b

Not sure whether this should be considered a bug in WeIRCd or a problem on our end.
authorShane Mc Cormack <shane@dmdirc.com>2009-07-03 18:19:03 (GMT)
commit4f3315aa6c1418158ec6d53e02b5606cfb097c79 (patch) (side-by-side diff)
Treat NOTICE messages with a source before 005 the same as we treat NOTICE messages without a source. (Needed for WeIRCd).
Fixes issue 2716.
Diffstat
-rw-r--r--src/com/dmdirc/parser/irc/IRCParser.java2
1 files changed, 1 insertions, 1 deletions
Click to Expand/Collapse
diff src/com/dmdirc/parser/irc/IRCParser.java
@@ -1015,7 +1015,7 @@ public class IRCParser implements Runnable {
if (got001) {
// Freenode sends a random notice in a stupid place, others might do aswell
// These shouldn't cause post005 to be fired, so handle them here.
- if (token[0].equalsIgnoreCase("NOTICE")) {
+ if (token[0].equalsIgnoreCase("NOTICE") || (token.length > 2 && token[2].equalsIgnoreCase("NOTICE"))) {
try { myProcessingManager.process("Notice Auth", token); } catch (ProcessorNotFoundException e) { }
return;
}

Issue History
Date Modified Username Field Change
2009-07-03 09:18 Error Reporter New Issue
2009-07-03 09:18 Error Reporter Status new => assigned
2009-07-03 09:18 Error Reporter Assigned To => Dataforce
2009-07-03 09:22 MD87 Note Added: 0007067
2009-07-03 09:23 MD87 Relationship added related to 0002697
2009-07-03 20:58 Dataforce Checkin
2009-07-03 20:58 Dataforce Note Added: 0007085
2009-07-03 20:58 Dataforce Status assigned => resolved
2009-07-03 20:58 Dataforce Resolution open => fixed
2009-11-08 12:53 Greboid Status resolved => closed
2009-11-21 22:56 MD87 Category *Unsorted => IRC Parser