Viewing Issue Advanced Details
ID 0003465 Category [DMDirc] *Unsorted Severity minor
Reproducibility always Date Submitted 2010-01-09 16:01 Last Update 2010-03-06 21:32
Reporter Greboid Assigned To Greboid View Status public
Priority normal Status closed Resolution fixed
Platform Fixed in Version Target Version 0.6.3
Product Version Product Build
Summary 0003465: addonbrowser also likes to eat cpu cycles for breakfast
Description addonbrowser also likes to eat cpu cycles for breakfast
Needs unit test no
Upstream Bug URL

Relationships

Notes
authorGregory Holmes <greg@dmdirc.com>2010-01-09 20:50:53 (GMT)
committer Chris Smith <chris@dmdirc.com>2010-01-09 20:54:00 (GMT)
commit823b4a9dc22f48daa8b9291ecac6064cec2a45ad (patch) (side-by-side diff)
issue 3465: addonbrowser also likes to eat cpu cycles for breakfast
This is not a compelte fix, but it does go some way to address it Change-Id: I3651c35b34439993f99e57c9aa2915f2208fe385 Reviewed-on: http://gerrit.dmdirc.com/408 Tested-by: Gregory Holmes <greboid@dmdirc.com> Reviewed-by: Chris Smith <chris@dmdirc.com> Tested-by: Chris Smith <chris@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/addons/ui_swing/components/addonbrowser/AddonInfoLabel.java33
1 files changed, 33 insertions, 0 deletions
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/components/addonbrowser/AddonInfoLabel.java
@@ -103,4 +103,37 @@ public class AddonInfoLabel extends JPanel {
public AddonInfo getAddonInfo() {
return addonInfo;
}
+
+ /** {@inheritDoc} */
+ @Override
+ public void invalidate() {
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public void revalidate() {
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public void repaint() {
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public void firePropertyChange(String propertyName, Object oldValue,
+ Object newValue) {
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public void firePropertyChange(String propertyName, boolean oldValue,
+ boolean newValue) {
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public void firePropertyChange(String propertyName, int oldValue,
+ int newValue) {
+ }
}
(0009728)
Version Control (developer)
2010-02-04 20:13

A patchset (1) related to this change has been added to gerrit by Gregory Holmes

Fixes issue 3465: addonbrowser also likes to eat cpu cycles for breakfast

Change-Id: I58f4a65d320d4fd34fe7f6652d2b39e5089e527a
(0009729)
Version Control (developer)
2010-02-04 20:14

A patchset (2) related to this change has been added to gerrit by Gregory Holmes

Fixes issue 3465: addonbrowser also likes to eat cpu cycles for breakfast

Change-Id: I58f4a65d320d4fd34fe7f6652d2b39e5089e527a
(0009731)
Version Control (developer)
2010-02-04 20:45

A patchset (3) related to this change has been added to gerrit by Gregory Holmes

Fixes issue 3465: addonbrowser also likes to eat cpu cycles for breakfast

Change-Id: I58f4a65d320d4fd34fe7f6652d2b39e5089e527a
(0009732)
Version Control (developer)
2010-02-04 20:46

A patchset (4) related to this change has been added to gerrit by Gregory Holmes

Fixes issue 3465: addonbrowser also likes to eat cpu cycles for breakfast

Change-Id: I58f4a65d320d4fd34fe7f6652d2b39e5089e527a
authorGregory Holmes <greg@dmdirc.com>2010-02-04 20:14:35 (GMT)
committer Shane Mc Cormack <shane@dmdirc.com>2010-02-04 22:40:11 (GMT)
commit97826854af833f67750c030ae615036f15a9b8bb (patch) (side-by-side diff)
Fixes issue 3465: addonbrowser also likes to eat cpu cycles for breakfast
Change-Id: I58f4a65d320d4fd34fe7f6652d2b39e5089e527a Reviewed-on: http://gerrit.dmdirc.com/848 Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com> Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/addons/ui_swing/components/addonbrowser/AddonInfoCellRenderer.java10
1 files changed, 8 insertions, 2 deletions
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/components/addonbrowser/AddonInfoCellRenderer.java
@@ -54,9 +54,15 @@ public class AddonInfoCellRenderer implements TableCellRenderer {
if (value instanceof AddonInfoLabel) {
final AddonInfoLabel label = (AddonInfoLabel) value;
- label.setBackground(row % 2 == 1 ? new Color(0xEE, 0xEE, 0xFF) : Color.WHITE);
+ final Color colour = row % 2 == 1 ? new Color(0xEE, 0xEE, 0xFF) : Color.WHITE;
+ if (!label.getBackground().equals(colour)) {
+ label.setBackground(colour);
+ }
- table.setRowHeight(row, label.getPreferredSize().height);
+ final int height = label.getPreferredSize().height;
+ if (table.getRowHeight(row) != height) {
+ table.setRowHeight(row, height);
+ }
return label;
} else {

Issue History
Date Modified Username Field Change
2010-01-09 16:01 Greboid New Issue
2010-01-09 16:01 Greboid Status new => assigned
2010-01-09 16:01 Greboid Assigned To => Greboid
2010-01-09 20:54 Greboid Checkin
2010-01-09 20:54 Greboid Note Added: 0008784
2010-02-04 20:13 Version Control Checkin
2010-02-04 20:13 Version Control Note Added: 0009728
2010-02-04 20:13 Version Control Status assigned => fix pending
2010-02-04 20:14 Version Control Checkin
2010-02-04 20:14 Version Control Note Added: 0009729
2010-02-04 20:45 Version Control Checkin
2010-02-04 20:45 Version Control Note Added: 0009731
2010-02-04 20:46 Version Control Checkin
2010-02-04 20:46 Version Control Note Added: 0009732
2010-02-04 22:41 Greboid Checkin
2010-02-04 22:41 Greboid Note Added: 0009740
2010-02-04 22:41 Greboid Status fix pending => resolved
2010-02-04 22:41 Greboid Resolution open => fixed
2010-03-06 21:32 Greboid Status resolved => closed