Viewing Issue Advanced Details
ID 0003702 Category [DMDirc] *Unsorted Severity minor
Reproducibility always Date Submitted 2010-02-01 00:10 Last Update 2010-03-07 19:11
Reporter Greboid Assigned To MD87 View Status public
Priority normal Status resolved Resolution fixed
Platform Fixed in Version Target Version 0.6.4
Product Version Product Build
Summary 0003702: Different action type for server/private notices
Description
server notice action stuff for notification colours
Needs unit test no
Upstream Bug URL

Relationships

Notes
(0009671)
MD87 (administrator)
2010-02-01 10:14

 Je ne comprends pas
(0009673)
Greboid (administrator)
2010-02-01 13:43

 It might already be possible, I'd like to have server notices shown in a different colour to other events in the frame managers.
(0009686)
MD87 (administrator)
2010-02-02 20:09

 Just an action then?

A patchset (1) related to this change has been added to gerrit by Chris Smith

New action type for server notices

Fixes issue 3702

Change-Id: Iac3112c64dc4b7d01aed19c1c3c6996148cce35a
authorChris Smith <chris@dmdirc.com>2010-03-07 17:33:35 (GMT)
committer Gregory Holmes <greg@dmdirc.com>2010-03-07 19:10:18 (GMT)
commitae9d5cb892fe1df790c9e16da0ff6e8a0a4844e0 (patch) (side-by-side diff)
New action type for server notices
Fixes issue 3702 Change-Id: Iac3112c64dc4b7d01aed19c1c3c6996148cce35a Reviewed-on: http://gerrit.dmdirc.com/985 Automatic-Compile: Chris Smith <chris@dmdirc.com> Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/ServerEventHandler.java2
-rw-r--r--src/com/dmdirc/actions/CoreActionType.java2
2 files changed, 3 insertions, 1 deletions
Click to Expand/Collapse
diff src/com/dmdirc/ServerEventHandler.java
@@ -194,7 +194,7 @@ public final class ServerEventHandler extends EventHandler implements
final String sHost) {
checkParser(tParser);
- owner.doNotification("serverNotice", CoreActionType.SERVER_NOTICE,
+ owner.doNotification("serverNotice", CoreActionType.SERVER_SERVERNOTICE,
owner.getParser().getClient(sHost), sMessage);
}
Click to Expand/Collapse
diff src/com/dmdirc/actions/CoreActionType.java
@@ -111,6 +111,8 @@ public enum CoreActionType implements ActionType {
/** Private notice received. */
SERVER_NOTICE(ServerEvents.SERVER_SOURCED_EVENT_WITH_ARG, "Notice received"),
+ /** Private server notice received. */
+ SERVER_SERVERNOTICE(ServerEvents.SERVER_SOURCED_EVENT_WITH_ARG, "Server notice received"),
/** MOTD starting. */
SERVER_MOTDSTART(ServerEvents.SERVER_EVENT_WITH_ARG, "Start of MOTD received"),

Issue History
Date Modified Username Field Change
2010-02-01 00:10 Greboid New Issue
2010-02-01 00:10 Greboid Status new => assigned
2010-02-01 00:10 Greboid Assigned To => MD87
2010-02-01 10:14 MD87 Note Added: 0009671
2010-02-01 10:14 MD87 Assigned To MD87 => Greboid
2010-02-01 10:14 MD87 Status assigned => feedback
2010-02-01 13:43 Greboid Note Added: 0009673
2010-02-01 13:43 Greboid Status feedback => assigned
2010-02-01 13:43 Greboid Assigned To Greboid => MD87
2010-02-02 20:09 MD87 Note Added: 0009686
2010-02-02 20:13 MD87 Needs unit test => no
2010-02-02 20:13 MD87 Target Version 0.6.3 => 0.6.4
2010-02-02 20:13 MD87 Summary server notice action stuff for notification colours => Different action type for server/private notices
2010-03-07 17:34 Version Control Checkin
2010-03-07 17:34 Version Control Note Added: 0010181
2010-03-07 17:34 Version Control Status assigned => fix pending
2010-03-07 19:11 MD87 Checkin
2010-03-07 19:11 MD87 Note Added: 0010187
2010-03-07 19:11 MD87 Status fix pending => resolved
2010-03-07 19:11 MD87 Resolution open => fixed