Viewing Issue Advanced Details
ID 0003743 Category [DMDirc] *Unsorted Severity minor
Reproducibility always Date Submitted 2010-02-06 23:34 Last Update 2010-03-06 21:32
Reporter Dataforce Assigned To Greboid View Status public
Priority normal Status closed Resolution fixed
Platform Fixed in Version Target Version 0.6.3
Product Version Product Build
Summary 0003743: nimbus LAF ignores background colour for topic bar
Description
nimbus LAF ignores background colour for topic bar
Needs unit test no
Upstream Bug URL

Relationships

Notes

A patchset (1) related to this change has been added to gerrit by Gregory Holmes

This issue is caused by the desired behaviour of nimbus, the workaround offered
by Sun has no effect, so I'm going to brute force a fix, which whilst horrible
works nicely across all platforms.

Fixes issue 3743: nimbus LAF ignores background colour for topic bar

Change-Id: Id6274a362572b7281b39e39763463cb78e433a06

A patchset (2) related to this change has been added to gerrit by Gregory Holmes

This issue is caused by the desired behaviour of nimbus, the workaround offered
by Sun has no effect, so I'm going to brute force a fix, which whilst horrible
works nicely across all platforms.

Fixes issue 3743: nimbus LAF ignores background colour for topic bar

Change-Id: Id6274a362572b7281b39e39763463cb78e433a06
authorGregory Holmes <greg@dmdirc.com>2010-02-07 21:10:10 (GMT)
committer Shane Mc Cormack <shane@dmdirc.com>2010-02-07 22:12:03 (GMT)
commit2789134c198df93301a0288fda6bf2df04cd0f2f (patch) (side-by-side diff)
This issue is caused by the desired behaviour of nimbus, the workaround offered by Sun has no effect, so I'm going to brute force a fix, which whilst horrible works nicely across all platforms.
Fixes issue 3743: nimbus LAF ignores background colour for topic bar Change-Id: Id6274a362572b7281b39e39763463cb78e433a06 Reviewed-on: http://gerrit.dmdirc.com/866 Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com> Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/addons/ui_swing/components/TextPaneInputField.java17
-rw-r--r--src/com/dmdirc/addons/ui_swing/components/TopicBar.java2
2 files changed, 18 insertions, 1 deletions
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/components/TextPaneInputField.java
@@ -30,7 +30,10 @@ import com.dmdirc.ui.interfaces.InputField;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
+import javax.swing.BorderFactory;
import javax.swing.JEditorPane;
+import javax.swing.plaf.ComponentUI;
+import javax.swing.plaf.basic.BasicEditorPaneUI;
import javax.swing.text.BadLocationException;
/**
@@ -94,4 +97,18 @@ public class TextPaneInputField extends JEditorPane implements InputField {
public void removeActionListener(ActionListener listener) {
//Ignore
}
+
+ /** {@inheritDoc} */
+ @Override
+ protected void setUI(final ComponentUI newUI) {
+ super.setUI(new BasicEditorPaneUI());
+ super.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public void updateUI() {
+ super.setUI(new BasicEditorPaneUI());
+ super.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
+ }
}
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/components/TopicBar.java
@@ -43,8 +43,8 @@ import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
-import javax.swing.AbstractAction;
+import javax.swing.AbstractAction;
import javax.swing.JButton;
import javax.swing.JComponent;
import javax.swing.JLabel;

Issue History
Date Modified Username Field Change
2010-02-06 23:34 Dataforce New Issue
2010-02-06 23:34 Dataforce Status new => assigned
2010-02-06 23:34 Dataforce Assigned To => Greboid
2010-02-07 21:11 Version Control Checkin
2010-02-07 21:11 Version Control Note Added: 0009779
2010-02-07 21:11 Version Control Status assigned => fix pending
2010-02-07 21:12 Version Control Checkin
2010-02-07 21:12 Version Control Note Added: 0009780
2010-02-07 22:13 Greboid Checkin
2010-02-07 22:13 Greboid Note Added: 0009781
2010-02-07 22:13 Greboid Status fix pending => resolved
2010-02-07 22:13 Greboid Resolution open => fixed
2010-03-06 21:32 Greboid Status resolved => closed