Viewing Issue Advanced Details

ID 0003754 Category [DMDirc] User Interface - Preferences Dialog Severity minor
Reproducibility always Date Submitted 2010-02-09 00:29 Last Update 2010-03-07 02:06
Reporter Demented-Idiot Assigned To Demented-Idiot View Status public
Priority normal Status resolved Resolution fixed
Platform Fixed in Version Target Version 0.6.4
Product Version Product Build
Summary 0003754: file path settings in prefs dialog should use new FileBrowser component
Description
file path settings in prefs dialog should use new FileBrowser component
Needs unit test no
Upstream Bug URL

Relationships

depends on 0001279resolvedDemented-Idiot Preferences dialog needs a file browse component 

Notes

A patchset (1) related to this change has been added to gerrit by Simon Mott

Changes all relevant Prefs settings to use the new FileBrowser component

Fixes issue 3754
authorSimon Mott <simon@dmdirc.com>2010-03-07 02:00:13 (GMT)
committer Gregory Holmes <greg@dmdirc.com>2010-03-07 02:05:48 (GMT)
commit83d8f8866975f674e0efb4ce5e925e59ac62a62e (patch) (side-by-side diff)
Changes all relevant Prefs settings to use the new FileBrowser component
Fixes issue 3754 Change-Id: I3b880c8c69d1629c38dea6c38a33e831ec961189 Reviewed-on: http://gerrit.dmdirc.com/968 Reviewed-by: Gregory Holmes <greg@dmdirc.com> Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com>
-rw-r--r--src/com/dmdirc/addons/dcc/DCCPlugin.java2
-rw-r--r--src/com/dmdirc/addons/freedesktop_notifications/FreeDesktopNotificationsPlugin.java2
-rw-r--r--src/com/dmdirc/addons/logging/LoggingPlugin.java2
3 files changed, 3 insertions, 3 deletions
Click to Expand/Collapse
diff src/com/dmdirc/addons/dcc/DCCPlugin.java
@@ -594,7 +594,7 @@ public final class DCCPlugin extends Plugin implements ActionListener {
firewall.addSetting(new PreferencesSetting(PreferencesType.INTEGER,
getDomain(), "firewall.ports.endPort", "End Port",
"Port to try to listen on last"));
- receiving.addSetting(new PreferencesSetting(PreferencesType.TEXT,
+ receiving.addSetting(new PreferencesSetting(PreferencesType.DIRECTORY,
getDomain(), "receive.savelocation", "Default save location",
"Where the save as window defaults to?"));
sending.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN,
Click to Expand/Collapse
diff src/com/dmdirc/addons/freedesktop_notifications/FreeDesktopNotificationsPlugin.java
@@ -197,7 +197,7 @@ public final class FreeDesktopNotificationsPlugin extends Plugin implements
final PreferencesCategory general = new PluginPreferencesCategory(getPluginInfo(), "FreeDesktop Notifications", "General configuration for FreeDesktop Notifications plugin.");
general.addSetting(new PreferencesSetting(PreferencesType.INTEGER, getDomain(), "general.timeout", "Timeout", "Length of time in seconds before the notification popup closes."));
- general.addSetting(new PreferencesSetting(PreferencesType.TEXT, getDomain(), "general.icon", "icon", "Path to icon to use on the notification."));
+ general.addSetting(new PreferencesSetting(PreferencesType.FILE, getDomain(), "general.icon", "icon", "Path to icon to use on the notification."));
general.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN, getDomain(), "advanced.escapehtml", "Escape HTML", "Some Implementations randomly parse HTML, escape it before showing?"));
general.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN, getDomain(), "advanced.strictescape", "Strict Escape HTML", "Strictly escape HTML or just the basic characters? (&, < and >)"));
general.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN, getDomain(), "advanced.stripcodes", "Strip Control Codes", "Strip IRC Control codes from messages?"));
Click to Expand/Collapse
diff src/com/dmdirc/addons/logging/LoggingPlugin.java
@@ -243,7 +243,7 @@ public class LoggingPlugin extends Plugin implements ActionListener,
final PreferencesCategory advanced = new PluginPreferencesCategory(
getPluginInfo(), "Advanced", "Advanced configuration for Logging plugin. You shouldn't need to edit this unless you know what you are doing.");
- general.addSetting(new PreferencesSetting(PreferencesType.TEXT, getDomain(), "general.directory", "Directory", "Directory for log files"));
+ general.addSetting(new PreferencesSetting(PreferencesType.DIRECTORY, getDomain(), "general.directory", "Directory", "Directory for log files"));
general.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN, getDomain(), "general.networkfolders", "Separate logs by network", "Should the files be stored in a sub-dir with the networks name?"));
general.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN, getDomain(), "general.addtime", "Timestamp logs", "Should a timestamp be added to the log files?"));
general.addSetting(new PreferencesSetting(PreferencesType.TEXT, getDomain(), "general.timestamp", "Timestamp format", "The String to pass to 'SimpleDateFormat' to format the timestamp"));

Issue History

Date Modified Username Field Change
2010-02-09 00:29 Demented-Idiot New Issue
2010-02-09 00:29 Demented-Idiot Status new => assigned
2010-02-09 00:29 Demented-Idiot Assigned To => Demented-Idiot
2010-02-09 00:30 Demented-Idiot Relationship added depends on 0001279
2010-02-09 00:30 Demented-Idiot Target Version 0.6.3 => 0.6.4
2010-02-09 00:36 Demented-Idiot Needs unit test => no
2010-02-09 00:36 Demented-Idiot Category *Unsorted => User Interface - Preferences Dialog
2010-03-07 02:01 Version Control Checkin
2010-03-07 02:01 Version Control Note Added: 0010128
2010-03-07 02:01 Version Control Status assigned => fix pending
2010-03-07 02:06 Version Control Checkin
2010-03-07 02:06 Version Control Note Added: 0010133
2010-03-07 02:06 Version Control Status fix pending => resolved
2010-03-07 02:06 Version Control Resolution open => fixed