Viewing Issue Advanced Details
ID 0003837 Category [DMDirc] *Unsorted Severity minor
Reproducibility always Date Submitted 2010-03-01 21:55 Last Update 2010-05-31 20:31
Reporter Greboid Assigned To Demented-Idiot View Status public
Priority normal Status assigned Resolution open
Platform Fixed in Version Target Version 0.6.5
Product Version Product Build
Summary 0003837: Rename treeview sort options, make window menu obey them
Description
Rename treeview sort options, make window menu obey them
Needs unit test no
Upstream Bug URL

Relationships
related to 0004040resolvedDemented-Idiot Button bar doesn't have any concept of button order (Needs to obey sort settings) 

Notes

A patchset (1) related to this change has been added to gerrit by Greboid

Rename treeview sort config options

issue 3837

Change-Id: I0302e13d8bf72b4af17a52d51ae527d266a7ce5a
authorGreboid <greg@dmdirc.com>2010-03-22 20:47:59 (GMT)
committer Shane Mc Cormack <shane@dmdirc.com>2010-03-22 21:52:58 (GMT)
commitda5e7aef92c4b4113b86b066d3b4c4a3a1fd32e9 (patch) (side-by-side diff)
Rename treeview sort config options
issue 3837 Change-Id: I0302e13d8bf72b4af17a52d51ae527d266a7ce5a Reviewed-on: http://gerrit.dmdirc.com/1180 Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com> Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/addons/ui_swing/SwingController.java12
-rw-r--r--src/com/dmdirc/addons/ui_swing/framemanager/tree/TreeFrameManager.java2
-rw-r--r--src/com/dmdirc/addons/ui_swing/framemanager/tree/TreeViewModel.java6
3 files changed, 10 insertions, 10 deletions
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/SwingController.java
@@ -793,6 +793,12 @@ public final class SwingController extends Plugin implements Serializable,
general.addSetting(new PreferencesSetting(PreferencesType.INTEGER,
"ui", "textPaneFontSize", "Textpane font size",
"Font size for the textpane"));
+ general.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN,
+ "ui", "sortrootwindows", "Sort root windows",
+ "Sort child windows in the frame managers?"));
+ general.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN,
+ "ui", "sortchildwindows", "Sort child windows",
+ "Sort root windows in the frame managers?"));
general.addSubCategory(createNicklistCategory());
general.addSubCategory(createTreeViewCategory());
@@ -870,12 +876,6 @@ public final class SwingController extends Plugin implements Serializable,
"ui", "treeviewRolloverColour", "Treeview rollover colour",
"Background colour to use when the mouse cursor is over a node"));
treeview.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN,
- "treeview", "sortwindows", "Sort windows",
- "Sort windows belonging to servers in the treeview?"));
- treeview.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN,
- "treeview", "sortservers", "Sort servers",
- "Sort servers in the treeview?"));
- treeview.addSetting(new PreferencesSetting(PreferencesType.BOOLEAN,
"ui", "treeviewActiveBold", "Active node bold",
"Make the active node bold?"));
treeview.addSetting(new PreferencesSetting(
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/framemanager/tree/TreeFrameManager.java
@@ -278,7 +278,7 @@ public final class TreeFrameManager implements FrameManager,
/** {@inheritDoc} */
@Override
public void configChanged(final String domain, final String key) {
- if ("sortservers".equals(key) || "sortwindows".equals(key)) {
+ if ("sortrootwindows".equals(key) || "sortchildwindows".equals(key)) {
redoTreeView();
} else {
setColours();
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/framemanager/tree/TreeViewModel.java
@@ -106,12 +106,12 @@ public class TreeViewModel extends DefaultTreeModel {
}
if (parent.equals(root) && !IdentityManager.getGlobalConfig().
- getOptionBool("treeview", "sortservers")) {
+ getOptionBool("ui", "sortrootwindows")) {
return parent.getChildCount();
}
- if (IdentityManager.getGlobalConfig().getOptionBool("treeview",
- "sortwindows")) {
+ if (IdentityManager.getGlobalConfig().getOptionBool("ui",
+ "sortchildwindows")) {
for (int i = 0; i < parent.getChildCount(); i++) {
final TreeViewNode child = (TreeViewNode) parent.getChildAt(i);
if (sortBefore(newChild, child)) {

Add Note
Note

Issue History
Date Modified Username Field Change
2010-03-01 21:55 Greboid New Issue
2010-03-01 21:55 Greboid Status new => assigned
2010-03-01 21:55 Greboid Assigned To => Greboid
2010-03-22 16:25 Greboid Relationship added related to 0004040
2010-03-22 20:48 Greboid Checkin
2010-03-22 20:48 Greboid Note Added: 0010763
2010-03-22 20:48 Greboid Assigned To Greboid => Demented-Idiot
2010-03-22 21:53 Greboid Checkin
2010-03-22 21:53 Greboid Note Added: 0010764
2010-05-31 20:31 MD87 Target Version 0.6.4 => 0.6.5