Viewing Issue Advanced Details
ID 0003857 Category [DMDirc] *Unsorted Severity minor
Reproducibility always Date Submitted 2010-03-07 02:07 Last Update 2010-03-17 23:57
Reporter Demented-Idiot Assigned To Demented-Idiot View Status public
Priority normal Status resolved Resolution fixed
Platform Fixed in Version Target Version 0.6.4
Product Version Product Build
Summary 0003857: FrameContainerMenuIterface should be called FrameContainerMenuInterface
Description
FrameContainerMenuIterface should be called FrameContainerMenuInterface
Needs unit test no
Upstream Bug URL

Relationships

Notes

A patchset (1) related to this change has been added to gerrit by Simon Mott

FrameContainerMenuIterface renamed to FrameContainerMenuInterface

Fixes issue 3857

Change-Id: I6c3cf98628911ca1fcb38ac43ab5e873ee44dcd1

A patchset (2) related to this change has been added to gerrit by Simon Mott

FrameContainerMenuIterface renamed to FrameContainerMenuInterface

Fixes issue 3857

Change-Id: I6c3cf98628911ca1fcb38ac43ab5e873ee44dcd1
authorSimon Mott <simon@dmdirc.com>2010-03-17 23:46:27 (GMT)
committer Gregory Holmes <greg@dmdirc.com>2010-03-17 23:56:37 (GMT)
commit603d50ac91253ee9d80c90df86f82067a6524ab0 (patch) (side-by-side diff)
FrameContainerMenuIterface renamed to FrameContainerMenuInterface
Fixes issue 3857 Change-Id: I6c3cf98628911ca1fcb38ac43ab5e873ee44dcd1 Reviewed-on: http://gerrit.dmdirc.com/1099 Reviewed-by: Gregory Holmes <greg@dmdirc.com> Automatic-Compile: Gregory Holmes <greg@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenu.java2
-rw-r--r--src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenuInterface.java (renamed from src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenuIterface.java)2
-rw-r--r--src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenuItem.java2
-rw-r--r--src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/WindowMenuFrameManager.java4
4 files changed, 5 insertions, 5 deletions
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenu.java
@@ -41,7 +41,7 @@ import javax.swing.SwingUtilities;
* Frame container JMenu.
*/
public class FrameContainerMenu extends JMenu implements FrameInfoListener,
- ActionListener, SelectionListener, FrameContainerMenuIterface {
+ ActionListener, SelectionListener, FrameContainerMenuInterface {
/**
* A version number for this class. It should be changed whenever the class
Click to Expand/Collapse
diff a/src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenuIterface.java b/src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenuIterface.java
@@ -27,7 +27,7 @@ import com.dmdirc.FrameContainer;
/**
* Interface to define a menu or menu item that holds a framecontainer.
*/
-public interface FrameContainerMenuIterface {
+public interface FrameContainerMenuInterface {
/**
* Returns the wrapped frame container.
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/FrameContainerMenuItem.java
@@ -40,7 +40,7 @@ import javax.swing.SwingUtilities;
* Action representing a frame.
*/
public class FrameContainerMenuItem extends JMenuItem implements FrameInfoListener,
- ActionListener, SelectionListener, FrameContainerMenuIterface {
+ ActionListener, SelectionListener, FrameContainerMenuInterface {
/**
* A version number for this class. It should be changed whenever the class
Click to Expand/Collapse
diff src/com/dmdirc/addons/ui_swing/framemanager/windowmenu/WindowMenuFrameManager.java
@@ -406,7 +406,7 @@ public final class WindowMenuFrameManager extends JMenu implements
}
});
for (int i = count; i < menuItemCount; i++) {
- if (!(menu.getMenuComponent(i) instanceof FrameContainerMenuIterface)) {
+ if (!(menu.getMenuComponent(i) instanceof FrameContainerMenuInterface)) {
continue;
}
final int index = i;
@@ -418,7 +418,7 @@ public final class WindowMenuFrameManager extends JMenu implements
setObject(menu.getMenuComponent(index));
}
});
- final FrameContainer child = ((FrameContainerMenuIterface) component).getFrame();
+ final FrameContainer child = ((FrameContainerMenuInterface) component).getFrame();
if (sortBefore(newChild, child)) {
return i;
} else if (!sortAfter(newChild, child) && IdentityManager.

Issue History
Date Modified Username Field Change
2010-03-07 02:07 Demented-Idiot New Issue
2010-03-07 02:07 Demented-Idiot Status new => assigned
2010-03-07 02:07 Demented-Idiot Assigned To => Greboid
2010-03-08 21:34 Greboid Assigned To Greboid => Demented-Idiot
2010-03-17 23:47 Demented-Idiot Checkin
2010-03-17 23:47 Demented-Idiot Note Added: 0010556
2010-03-17 23:47 Demented-Idiot Status assigned => fix pending
2010-03-17 23:49 Demented-Idiot Checkin
2010-03-17 23:49 Demented-Idiot Note Added: 0010558
2010-03-17 23:57 Demented-Idiot Checkin
2010-03-17 23:57 Demented-Idiot Note Added: 0010560
2010-03-17 23:57 Demented-Idiot Status fix pending => resolved
2010-03-17 23:57 Demented-Idiot Resolution open => fixed