Viewing Issue Advanced Details
ID 0003895 Category [DMDirc] Core Severity minor
Reproducibility always Date Submitted 2010-03-10 17:20 Last Update 2010-03-16 11:19
Reporter Error Reporter Assigned To MD87 View Status public
Priority normal Status resolved Resolution fixed
Platform Fixed in Version Target Version 0.6.4
Product Version Product Build 0.6.3-45-g1d95f6c
Summary 0003895: Error processing action: null — FrameContainer.ownsFrame(FrameContainer.java:263)
Description
java.lang.NullPointerException
com.dmdirc.FrameContainer.ownsFrame(FrameContainer.java:263)
com.dmdirc.Server.ownsFrame(Server.java:661)
com.dmdirc.addons.lagdisplay.LagDisplayPlugin.processEvent(LagDisplayPlugin.java:171)
com.dmdirc.actions.ActionManager.processEvent(ActionManager.java:382)
com.dmdirc.ServerEventHandler.onPingSuccess(ServerEventHandler.java:253)
sun.reflect.GeneratedMethodAccessor40.invoke(Unknown Source)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.lang.reflect.Method.invoke(Method.java:616)
com.dmdirc.parser.common.CallbackObject.call(CallbackObject.java:151)
com.dmdirc.parser.irc.IRCParser.callPingSuccess(IRCParser.java:637)
com.dmdirc.parser.irc.IRCParser.processLine(IRCParser.java:1101)
com.dmdirc.parser.irc.IRCParser.run(IRCParser.java:882)
java.lang.Thread.run(Thread.java:636)
Needs unit test no
Upstream Bug URL

Relationships
has duplicate 0003896closedMD87 Exception in callback (null) — Server.addLineToAll(Server.java:1168) 

Notes

A patchset (1) related to this change has been added to gerrit by Chris Smith

Handle null frames in ownsFrame

Fixes issue 3895

Change-Id: I1289b2b97cbf41971812ca7a077973b63156ea6b
authorChris Smith <chris@dmdirc.com>2010-03-16 05:57:06 (GMT)
committer Gregory Holmes <greg@dmdirc.com>2010-03-16 11:18:43 (GMT)
commitd10397ade3e8530c97534a234bd6ab69e3165899 (patch) (side-by-side diff)
Handle null frames in ownsFrame
Fixes issue 3895 Change-Id: I1289b2b97cbf41971812ca7a077973b63156ea6b Reviewed-on: http://gerrit.dmdirc.com/1064 Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com> Reviewed-by: Gregory Holmes <greg@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/FrameContainer.java3
1 files changed, 2 insertions, 1 deletions
Click to Expand/Collapse
diff src/com/dmdirc/FrameContainer.java
@@ -260,7 +260,8 @@ public abstract class FrameContainer {
* @return True iff frame is owned by this container, false otherwise
*/
public boolean ownsFrame(final Window target) {
- return getFrame().equals(target);
+ final Window window = getFrame();
+ return window != null && window.equals(target);
}
/**

Issue History
Date Modified Username Field Change
2010-03-10 17:20 Error Reporter New Issue
2010-03-10 17:20 Error Reporter Status new => assigned
2010-03-10 17:20 Error Reporter Assigned To => MD87
2010-03-10 18:41 MD87 Relationship added has duplicate 0003896
2010-03-10 18:41 MD87 View Status private => public
2010-03-16 05:57 MD87 Checkin
2010-03-16 05:57 MD87 Note Added: 0010460
2010-03-16 05:57 MD87 Status assigned => fix pending
2010-03-16 11:19 MD87 Checkin
2010-03-16 11:19 MD87 Note Added: 0010472
2010-03-16 11:19 MD87 Status fix pending => resolved
2010-03-16 11:19 MD87 Resolution open => fixed