Viewing Issue Advanced Details
ID 0003901 Category [DMDirc] *Unsorted Severity minor
Reproducibility always Date Submitted 2010-03-10 18:14 Last Update 2010-03-15 01:05
Reporter MD87 Assigned To MD87 View Status public
Priority normal Status resolved Resolution fixed
Platform Fixed in Version Target Version 0.6.4
Product Version Product Build
Summary 0003901: Commands shouldn't strip trailing whitespace
Description
Commands shouldn't strip trailing whitespace
Needs unit test no
Upstream Bug URL

Relationships

Notes

A patchset (1) related to this change has been added to gerrit by Chris Smith

Fix commands losing their trailing whitespace

Fixes issue 3901

Change-Id: Ic2293c067d7fa673dec9ce4a32127f87fe52c35f
authorChris Smith <chris@dmdirc.com>2010-03-15 00:41:15 (GMT)
committer Shane Mc Cormack <shane@dmdirc.com>2010-03-15 01:04:10 (GMT)
commit951640157e6d3842a823af74cd8183a90c182c07 (patch) (side-by-side diff)
Fix commands losing their trailing whitespace
Fixes issue 3901 Change-Id: Ic2293c067d7fa673dec9ce4a32127f87fe52c35f Reviewed-on: http://gerrit.dmdirc.com/1040 Automatic-Compile: DMDirc Local Commits <dmdirc@googlemail.com> Reviewed-by: Shane Mc Cormack <shane@dmdirc.com>
Diffstat
-rw-r--r--src/com/dmdirc/commandparser/CommandArguments.java2
1 files changed, 1 insertions, 1 deletions
Click to Expand/Collapse
diff src/com/dmdirc/commandparser/CommandArguments.java
@@ -177,7 +177,7 @@ public class CommandArguments {
Logger.assertTrue(start <= end + 1);
final Pattern pattern = Pattern.compile("(\\S+\\s+){" + (start) + "}"
- + "((\\S+\\s+){" + Math.max(0, end - start) + "}\\S+).*?");
+ + "((\\S+\\s+){" + Math.max(0, end - start) + "}\\S+(\\s+$)?).*?");
final Matcher matcher = pattern.matcher(line);
return matcher.matches() ? matcher.group(2) : "";

Issue History
Date Modified Username Field Change
2010-03-10 18:14 MD87 New Issue
2010-03-10 18:14 MD87 Status new => assigned
2010-03-10 18:14 MD87 Assigned To => MD87
2010-03-15 00:42 MD87 Checkin
2010-03-15 00:42 MD87 Note Added: 0010399
2010-03-15 00:42 MD87 Status assigned => fix pending
2010-03-15 01:05 MD87 Checkin
2010-03-15 01:05 MD87 Note Added: 0010400
2010-03-15 01:05 MD87 Status fix pending => resolved
2010-03-15 01:05 MD87 Resolution open => fixed